moonpower/P3DS-test
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Qt: Fix race condition when using cheats (#792)

Browse Source 
* Qt: Fix race condition when using cheats

* Nit
This commit is contained in:
wheremyfoodat
2025-07-24 17:17:40 +03:00
committed by GitHub
parent f8c3ddff9a
commit 3ac5f1b0c6
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/panda_qt/cheats_window.cpp
View File

@@ -70,8 +70,6 @@ void CheatEntryWidget::editClicked() {
CheatEditDialog::CheatEditDialog(Emulator* emu, CheatEntryWidget& cheatEntry) : QDialog(), emu(emu), cheatEntry(cheatEntry) { CheatEditDialog::CheatEditDialog(Emulator* emu, CheatEntryWidget& cheatEntry) : QDialog(), emu(emu), cheatEntry(cheatEntry) {
setWindowTitle(tr("Edit Cheat")); setWindowTitle(tr("Edit Cheat"));
setAttribute(Qt::WA_DeleteOnClose);
setModal(true); setModal(true);
QVBoxLayout* layout = new QVBoxLayout; QVBoxLayout* layout = new QVBoxLayout;
@@ -147,6 +145,9 @@ void CheatEditDialog::accepted() {
cheatEntry.setMetadata(metadata); cheatEntry.setMetadata(metadata);
cheatEntry.Update(); cheatEntry.Update();
} }
// Delete the CheatEditDialog when the main thread is done using it
QObject::deleteLater();
}); });
}); });
} }
@@ -157,6 +158,9 @@ void CheatEditDialog::rejected() {
// Was adding a cheat but user pressed cancel // Was adding a cheat but user pressed cancel
cheatEntry.Remove(); cheatEntry.Remove();
} }
// We have to manually memory-manage the CheatEditDialog object since it's accessed via multiple threads
QObject::deleteLater();
} }
CheatsWindow::CheatsWindow(Emulator* emu, const std::filesystem::path& cheatPath, QWidget* parent) CheatsWindow::CheatsWindow(Emulator* emu, const std::filesystem::path& cheatPath, QWidget* parent)