moonpower/P3DS-test
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

config: Use error_code prototype of filesystem::exists

Browse Source 
The non-error-code version of these functions are susceptible to
throwing an exception in the case of system errors like permission
issues or underlying device errors.
This commit is contained in:
Wunkolo
2023-07-10 10:46:47 -07:00
parent 5f9db9c1cd
commit 5372fe6e43
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/config.cpp
View File

@@ -11,7 +11,8 @@
void EmulatorConfig::load(const std::filesystem::path& path) { void EmulatorConfig::load(const std::filesystem::path& path) {
// If the configuration file does not exist, create it and return // If the configuration file does not exist, create it and return
if (!std::filesystem::exists(path)) { std::error_code error;
if (!std::filesystem::exists(path, error)) {
save(path); save(path);
return; return;
} }
@@ -38,13 +39,19 @@ void EmulatorConfig::load(const std::filesystem::path& path) {
void EmulatorConfig::save(const std::filesystem::path& path) { void EmulatorConfig::save(const std::filesystem::path& path) {
toml::basic_value<toml::preserve_comments> data; toml::basic_value<toml::preserve_comments> data;
if (std::filesystem::exists(path)) { std::error_code error;
if (std::filesystem::exists(path, error)) {
try { try {
data = toml::parse<toml::preserve_comments>(path); data = toml::parse<toml::preserve_comments>(path);
} catch (std::exception& ex) { } catch (std::exception& ex) {
Helpers::warn("Got exception trying to save config file. Exception: %s\n", ex.what()); Helpers::warn("Exception trying to parse config file. Exception: %s\n", ex.what());
return; return;
} }
} else {
if (error) {
Helpers::warn("FileSystem error accessing %s %s\n", path.string().c_str(), error.message().c_str());
}
Helpers::warn("Saving new configuration file %s \n", path.string().c_str());
} }
data["GPU"]["EnableShaderJIT"] = shaderJitEnabled; data["GPU"]["EnableShaderJIT"] = shaderJitEnabled;