moonpower/P3DS-test
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: do not allocate exheader on the stack as it has a variable length

Browse Source 
Fix build on Windows hopefully.
This commit is contained in:
Mary
2023-06-20 08:35:48 +02:00
parent 6bdc754e86
commit ef5329a0d4
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/loader/ncch.cpp
View File

@@ -102,9 +102,9 @@ bool NCCH::loadFromHeader(Crypto::AESEngine &aesEngine, IOFile& file, const FSIn
} }
if (exheaderSize != 0) { if (exheaderSize != 0) {
u8 exheader[exheaderSize]; std::unique_ptr<u8[]> exheader(new u8[exheaderSize]);
auto [success, bytes] = readFromFile(file, info, exheader, 0x200, exheaderSize); auto [success, bytes] = readFromFile(file, info, &exheader[0], 0x200, exheaderSize);
if (!success || bytes != exheaderSize) { if (!success || bytes != exheaderSize) {
printf("Failed to read Extended NCCH header\n"); printf("Failed to read Extended NCCH header\n");
return false; return false;
@@ -120,7 +120,7 @@ bool NCCH::loadFromHeader(Crypto::AESEngine &aesEngine, IOFile& file, const FSIn
} }
// If it's truely encrypted, we need to read section again. // If it's truely encrypted, we need to read section again.
if (encrypted) { if (encrypted) {
auto [success, bytes] = readFromFile(file, exheaderInfo, exheader, 0, exheaderSize); auto [success, bytes] = readFromFile(file, exheaderInfo, &exheader[0], 0, exheaderSize);
if (!success || bytes != exheaderSize) { if (!success || bytes != exheaderSize) {
printf("Failed to read Extended NCCH header\n"); printf("Failed to read Extended NCCH header\n");
return false; return false;