Commit Graph
17 Commits
Author SHA1 Message Date
Ian Chamberlain 025913a734 Fix string_view constructor for macOS clang
Some versions of clang 14 (macOS+android) don't implement
`string_view(It first, It last)`, so let's use
`string_view(const CharT*, size_type)` instead.

Also remove unused header leftover from old code that uses std::string.
2023-04-11 10:06:08 -04:00
Ian Chamberlain 4cc181e5b8 Address review comments
Use more modern C++ style casts + std::array, clean up some log
messages, and rename some functions.
2023-04-05 12:41:17 -04:00
Ian Chamberlain 696c0904f8 Update some c-style casts -> reinterpret_cast 2023-04-04 13:21:25 -04:00
Ian Chamberlain 6e45de760e Cleanup new code, add docs and error handling 2023-04-04 13:13:24 -04:00
Ian Chamberlain 0d4c93d1c2 Undo some changes exposing unused functions 2023-04-04 12:20:41 -04:00
Ian Chamberlain 351730d585 Fix infinite hang if GDB client kills gdbstub 2023-03-31 14:06:43 -04:00
Ian Chamberlain 83138e0c63 Fix some build + impl errors with HIO
After rebase there were some API changes, also fix continuation logic in
the main gdbstub.
2023-03-31 14:05:57 -04:00
Ian Chamberlain 33dde0d06b Update default config example for log_filter
As far as I can tell, this log filter does not actually support
wildcards in the subclass.
2023-03-31 13:54:47 -04:00
Ian Chamberlain f92f494cab Stop execution when performing HIO request
Since the HIO request is basically treated like a syscall, we need to
stop emulation while waiting for the GDB client to reply with the
result. This ensures any memory queries etc. that GDB makes to fulfill
the HIO request are accessing memory as it was at the time of the
request, instead of afterwards.
2023-03-29 09:09:32 -04:00
Ian Chamberlain b9c11e71d7 Fix ABI mismatch in packed HIO request
Using size_t etc. is incorrect, since these definitions are based on the
build machine which most likely has a different arch than the 3DS.
2023-03-29 09:09:32 -04:00
Ian Chamberlain 874bfebaf9 Add some notes + use stringstream to build packet 2023-03-29 09:09:32 -04:00
Ian Chamberlain 7de1bf3746 Properly parse incoming hio packet
This also does kind of a hacky way of sending HIO requests, since we
don't have a direct way of signaling a request should be sent like the
Rosalina implementation.

To improve this, it could probably do some kind of signal sending which
the main run loop handles instead of GDBStub::HandlePacket();
2023-03-29 09:09:32 -04:00
Ian Chamberlain 6f23ee43ae Initial port of luma3ds' gdb_hio to Citra 2023-03-29 09:09:32 -04:00
Ian Chamberlain 24b54a9b01 Follow convention and break in default case 2022-08-23 08:22:17 -04:00
Ian Chamberlain 401336c5e7 Rename Close() -> RequestClose() 2022-08-22 18:11:26 -04:00
Ian Chamberlain c634c263db citra-sdl: use the result of system.RunLoop()
If a shutdown was requested by the application, close the SDL window,
initiating the normal shutdown procedure. This causes a graceful exit
process instead of hanging.
2022-08-20 20:49:59 -04:00
Ian Chamberlain a90b0daebe Look at version_major.h when for newer ffmpeg libs
In ffmpeg 5.1, it seems most (or all) of these libraries use a separate
version_major.h, so the logic to check minimum version didn't work
without looking at the major version file.
2022-08-20 20:40:26 -04:00