Mat M and GitHub
a5f906b8ab
Merge pull request #3708 from FearlessTobi/add-region-column
...
citra_qt: Add a game region column to the Game List
2018-05-02 00:22:38 -04:00
Mat M and GitHub
c250cbd5b3
Merge pull request #3660 from baka0815/translation
...
Don't translate function keys in Qt GUI
2018-04-16 08:12:29 -04:00
Lioncash
a78920e60b
sm: Relocate the service manager to the System class
...
Rather than have it live as a global variable, place it into the System class and make it instance-based.
2018-04-13 07:15:34 -04:00
Lioncash
5309b51c12
cam: Correct forward declaration type for Core::EventType
...
This is actually a struct, not a class.
2018-04-12 23:15:16 -04:00
Mat M and GitHub
bdf7b46fbb
Merge pull request #3641 from valentinvanelslande/default_ini
...
default_ini: remove space in custom_layout
2018-04-09 02:00:20 -04:00
Mat M and GitHub
5b9253d710
Merge pull request #3600 from lioncash/array
...
pica_to_gl: Use std::array where applicable
2018-03-31 02:57:47 -04:00
Lioncash
7d331a469f
pica_to_gl: Use std::array where applicable
...
Removes the need to use the ARRAY_SIZE macro
2018-03-31 00:58:49 -04:00
Lioncash
0e7ca706dc
disk_archive: Make DiskDirectory's constructor explicit
...
Prevents implicit conversions/construction.
2018-03-31 00:54:17 -04:00
Lioncash
07855c48d1
disk_archive: Remove unnecessary const in DiskDirectory's Read() declaration
...
This only applies in the definition of the function, not the
declaration.
2018-03-31 00:54:17 -04:00
Lioncash
ed64d15060
disk_archive: Remove unused total_entries_in_directory member from DiskDirectory
...
Also converts initializer list assignments to in-class initializers
where relevant.
2018-03-31 00:52:47 -04:00
Lioncash
26b1aec3c1
archive_systemsavedata: Remove pointer cast from GetSystemSaveDataPath()
...
These kinds of casts invoke undefined behavior due to alignment rules.
Use memcpy instead which always does the right thing.
2018-03-28 22:17:26 -04:00
Lioncash
8366f6cb5e
citra-room: Fix always false case in main() related to port range
...
If the variable we're checking is a u16, then there can never be values
outside of the 0-65535 range. This is bad because an arbitrary larger
value can be truncated down into a valid value, making an otherwise
malformed argument well-formed.
Change it to use u32 to allow the check to function properly.
2018-03-28 21:53:05 -04:00
Lioncash
38b9d1780f
verify_login: Make VerifyLogin exceptionless
...
This function can be simplified by attempting to find the username
within the JSON object and then only accessing it if it does. There's no
need to blindly access the data itself.
This also eliminates the need to copy the string to a local as well,
since we already have the element itself, we can just compare against
it. For the failure case, it's the same if we were checking that the
provided username string is empty.
2018-03-28 21:34:21 -04:00
Lioncash
27a3d44b16
gl_rasterizer: Fix incorrect comparison against src_surface in AccelerateTextureCopy()
...
This should actually be comparing the validity of the destination
surface.
2018-03-28 21:13:57 -04:00
Lioncash
5ec576ff78
err_f: Add missing break in ThrowFatalError()
...
Introduced by 691f069743
If we hit a prefetch abort, the DFSR and DFAR contents aren't really going to be
that useful.
2018-03-28 20:33:25 -04:00
Lioncash
31100c582a
boss: Correct ReceiveProperty()'s response data payload
...
This was previously overwriting data in the same index.
2018-03-28 20:26:33 -04:00
Lioncash
3af976e41e
ncch_container: Get rid of pointer casts in LZSS_GetDecompressedSize() and LZSS_Decompress()
...
These kinds of casts invoke undefined behavior, due to both the aliasing
rule, and from an alignment point-of-view. Use the way that's guaranteed
to always work instead.
2018-03-28 19:55:49 -04:00
Mat M and GitHub
79d1bcf5ba
Merge pull request #3506 from MerryMage/mov-gl_resource_manager
...
gl_resource_manager: Use std::exchange in move assignment operators and constructors
2018-03-17 16:30:58 -04:00
Mat M and GitHub
5dd8ac99e3
Merge pull request #3466 from daniellimws/edit-contributing
...
Add link to Discord
2018-03-09 21:14:17 -05:00
Mat M and GitHub
2085c9d7df
Merge pull request #3487 from wwylele/no-cached-io
...
Memory: remove RasterizerCachedSpecial page type
2018-03-09 21:13:20 -05:00
Lioncash
e4b38fdb80
externals: Update catch to v2.1.1
2018-01-27 15:45:29 -05:00
Lioncash
f2fb830859
externals: Update catch to 2.1.0
...
Keeps the unit testing library up to date.
2018-01-17 20:52:47 -05:00
Mat M and GitHub
c143a5a3a6
Merge pull request #3318 from MerryMage/gdb_stub_
...
gdbstub: Correct typo
2017-12-20 15:05:37 -05:00
Lioncash
a73f135868
citra_qt: Migrate to Qt 5 signal/slot connection syntax where applicable
...
This is more type-safe than the string-based signal/slot syntax that was
being used. It also makes the connections throughout the UI code consistent.
2017-12-17 18:44:48 -05:00
Lioncash
9ec0609ae5
citra_qt: Drop Qt 5 version checks in code
...
We don't support Qt 4.x anymore.
2017-12-16 13:26:14 -05:00
Lioncash
8e53599deb
game_list: Use forward declarations where applicable
...
Reduces the number of header dependencies propagated by the header file.
2017-12-16 13:14:23 -05:00
Mat M and GitHub
d3112aedba
Merge pull request #3295 from lioncash/qt4
...
citra_qt: CMakeLists: Drop leftover handling code for Qt 4 UI files
2017-12-15 19:49:22 -05:00
Lioncash
d613c6f74f
mic_u: Migrate to the new service framework
2017-12-15 19:22:58 -05:00
Lioncash
c681090d06
citra_qt: CMakeLists: Drop leftover handling code for Qt 4 UI files
...
We don't support Qt 4 anymore.
2017-12-15 19:01:21 -05:00
Lioncash
761101f64c
input_common: Remove redundant target_sources in CMakeLists
2017-12-14 19:21:02 -05:00
Lioncash
ab021d163e
CMakeLists: Derive the source directory grouping from targets themselves
...
Removes the need to store to separate SRC and HEADER variables,
and then construct the target in most cases.
2017-12-11 21:11:52 -05:00
Lioncash
eb58dbda32
ncch: Add missing return statement in ReadUpdateRomFs
2017-12-11 01:33:08 -05:00
Lioncash
91a804707b
ipc_helpers: Add member functions for pushing and popping strongly typed enums
...
Alleviates the need to static_cast to an enum type at the call sites of the Push and Pop calls.
We only allow strongly typed enums, as they have a defined type of int
by default if an underlying type isn't explicitly specified, whereas
with regular enums, if an underlying type isn't specified, an
implementation-defined type is used that can fit all the enumeration
values.
2017-12-10 23:10:00 -05:00
Lioncash
e439725271
bootmanager: Make EmuThread's IsRunning() member function const
2017-12-10 20:12:47 -05:00
Lioncash
c06f7978ac
bootmanager: In-class initialize EmuThread's boolean member variables
...
Trims down the initializer list a little.
2017-12-10 20:11:35 -05:00
Lioncash
1f186be030
input_common/sdl: Silence a -Wpessimizing-move warning
...
Moving when returning by value can inhibit copy elision.
2017-12-10 19:53:57 -05:00
Lioncash
c31f932afe
common/core: Silence initialization order warnings
2017-12-10 19:50:45 -05:00
Lioncash
bca58546b1
ac: Correct constructor initialization order
...
The parent class constructor will always run before the
class' initializers for member variables.
2017-12-09 23:48:40 -05:00
Lioncash
11705857cd
file_sys: std::move the vector in NCCHFile's constructor
...
Avoids making unnecessary copies of the source vector's data.
2017-12-09 14:33:09 -05:00
Lioncash
370d77f13a
file_sys: std::move std::shared_ptr instances in constructors where applicable
...
By default, a regular copy requires an atomic increment and decrement. A
move avoids this from occurring, which makes sense when the constructor
is taking the shared_ptr by value.
2017-12-09 14:33:04 -05:00
Lioncash
ff96c5dba0
svc: Provide names for svc 0x59 and 0x5A
...
Updated according to 3dbrew.
2017-12-07 22:14:55 -05:00
Lioncash
088c8521bf
dyncom: Remove unnecessary includes
2017-12-07 00:02:55 -05:00
Lioncash
ab857f5e45
arm_dyncom_dec: Hide the decoding table from external view
...
This isn't used externally anywhere (and really shouldn't be).
2017-12-06 20:55:52 -05:00
Lioncash
982039be95
arm_dynarmic_cp15: Add missing header guard
2017-12-06 19:51:46 -05:00
Lioncash
e960628a14
arm: Make CPU backend constructors explicit
...
Avoids implicit conversions
2017-12-06 19:37:56 -05:00
Lioncash
8599b1e7cc
dyncom: Convert the SPSR checking define to a function
...
Same thing, with less indirection hiding
2017-12-05 20:07:45 -05:00
Lioncash
cc2ff226ae
vector_math: Return by const reference for const operator[]
...
Makes behavior between both overloads consistent.
2017-12-03 19:35:54 -05:00
Lioncash
f51fa38a1b
externals: Update catch to v2.0.1
2017-11-29 19:19:33 -05:00
Lioncash
89f67ad90f
services: Silence warnings related to logging
2017-11-29 18:59:54 -05:00
Lioncash
94999bde5b
room/room_member: Silence -Wswitch warnings
2017-11-28 21:09:53 -05:00
Lioncash
0a988e07cb
packet: Simplify operator bool overload
...
Previously this would cause a -Wnull-conversion warning
2017-11-28 21:00:24 -05:00
Lioncash
e74ada0a73
externals: Update catch to 1.9.4
2017-05-21 19:29:21 -04:00
Mat M and GitHub
b29239506f
Merge pull request #2651 from jroweboy/configmoved
...
citra-qt: Move config dialog code to its own directory
2017-04-04 13:14:08 -04:00
Lioncash and James Rowe
1631e99eed
citra-qt: Move config dialog code to its own directory
2017-04-03 20:43:13 -06:00
Mat M and Yuri Kunde Schlesner
0cb52ee74a
Doxygen: Amend minor issues ( #2593 )
...
Corrects a few issues with regards to Doxygen documentation, for example:
- Incorrect parameter referencing.
- Missing @param tags.
- Typos in @param tags.
and a few minor other issues.
2017-02-26 17:58:51 -08:00
Mat M and GitHub
5472528202
Merge pull request #2571 from wwylele/missing-file
...
core: add missing errors.h in CMakeLists.txt
2017-02-15 11:19:06 -05:00
Mat M and GitHub
05a6f243f8
Merge pull request #2534 from Lectem/fix_etc1_msvc15
...
Use std::array<u8,2> instead of u8[2] to fix MSVC build
2017-02-05 09:09:42 -05:00
Lioncash
8309d0dade
citra-qt: Move graphics debugging code into its own folder
...
Keeps all graphics debugging stuff from cluttering up the root debugger
folder
2016-12-21 17:19:21 -05:00
Lioncash
f2c307557a
disassembler: Remove mutable specifier from breakpoints member variable
...
Breakpoints has been const correct with regards to what the
DisassmblerModel needs for quite a while now.
2016-12-21 14:12:41 -05:00
Lioncash
cc1f2c131b
citra-qt: Move bits of constructor behavior to named functions
...
Makes the initialization process a tad easier to grok,
since the constructor isn't just a glob of random unrelated behaviors.
2016-12-19 15:12:28 -05:00
Lioncash
38a964735f
gdbstub: const correctness changes
...
Also uses size_t as the length indicator type, as is common with buffers.
2016-12-16 04:06:26 -05:00
Lioncash
ba20dd9b61
gdbstub: Remove global variable from public interface
...
Currently, this is only ever queried, so adding a function to check if the
server is enabled is more sensible.
If directly modifying this externally is ever desirable, it should be done
by adding a function to the interface, rather than exposing implementation
details directly.
2016-12-15 16:37:22 -05:00
Lioncash
3faa675d6b
hid: Get rid of a double -> float truncation warning
...
float literals need to have the 'f' prefix.
2016-12-15 15:52:15 -05:00
Lioncash
2f3c1bdfb4
core: Add missing #pragma once directives where applicable
2016-12-15 15:40:51 -05:00
Lioncash
d467b5ce4f
act: Fix docstring typo
...
These aren't the AM services.
2016-12-15 14:51:45 -05:00
Lioncash
efcab1e918
time_stretch: Add missing #pragma once directive
2016-12-12 19:16:46 -05:00
Lioncash and linkmauve
d0e4d1182b
citra-qt: Make constructors explicit where applicable
2016-12-11 14:18:06 +00:00
Lioncash and linkmauve
327b23e4ce
citra-qt: Add missing #pragma once directives
2016-12-11 12:12:03 +00:00
Lioncash and linkmauve
3bbd35dde9
game_list: Make slots private functions
...
The new Qt event syntax allows for regular member functions to be used in
connect(), so explicitly indicating slots isn't necessary.
2016-12-11 11:45:50 +00:00
Lioncash and linkmauve
7402001787
game_list: Make the constructor explicit
2016-12-11 11:45:50 +00:00
Lioncash and linkmauve
db33d7668e
game_list: Make the AddEntry argument a const reference
...
appendRow takes a QList by const reference, so it doesn't need to be
modifiable.
2016-12-11 11:45:50 +00:00
Lioncash and linkmauve
aa05d36823
game_list: Replace 0 literals with nullptr
2016-12-11 11:45:50 +00:00
Lioncash and linkmauve
dd4582f85d
game_list: Use QT5's new event connection syntax
...
Makes for more compact code in most places.
2016-12-11 11:45:50 +00:00
Lioncash and linkmauve
fd3d56740e
game_list: Pass the parent constructor argument to the QWidget base class
...
If the control was ever passed an explicit parent, a potential memory leak
would happen, as the game list wouldn't be freed.
However, in our case, the game list was placed within a layout, which
automatically performs reparenting, avoiding this issue.
2016-12-11 11:45:50 +00:00
Lioncash
4e7092881f
graphics_cmdlists: Get rid of variable shadowing
2016-12-11 04:33:24 -05:00
Lioncash
1e5644935d
graphics_cmdlists: Get rid of an unused variable
2016-12-10 20:01:27 -05:00
Lioncash
f1ee7e4e0e
graphics_cmdlists: Make LoadTexture and TextureInfoWidget src arguments const
2016-12-10 20:01:22 -05:00
Lioncash
dcb8113347
graphics_cmdlists: Make LoadImage internally linked
...
Puts the TextureInfoWidget definition in the anonymous namespace as well,
as it's only used in the translation unit as well.
2016-12-10 20:00:40 -05:00
Lioncash and linkmauve
963aedd8cc
Add all services to the Service namespace
...
Previously there was a split where some of the services were in the
Service namespace and others were not.
2016-12-11 00:07:27 +00:00
Lioncash
a2d69adad1
service: Add cfg:nor service
2016-12-09 05:07:41 -05:00
Lioncash
934b8ffcf8
ptm: Use boolean instead of integral value
...
The third parameter of Write is actually a bool type, not an int.
2016-12-09 04:04:28 -05:00
Lioncash
823d58ac9b
service: Drop '_Interface' from cfg service names
2016-12-09 01:08:35 -05:00
Lioncash
007815647c
service: Add the ptm:s service
...
3dbrew documents this as being the exact same as ptm:sysm
2016-12-08 06:14:55 -05:00
Lioncash
56656b75ab
service: Add common ptm:u commands to other ptm services
...
3dbrew indicates that all services have access to these commands
except for ptm:sets.
2016-12-08 06:13:10 -05:00
Lioncash
cd778cf991
service: Drop '_Interface' in ptm service class names
...
Inheriting from Service::Interface makes this obvious.
2016-12-08 06:13:04 -05:00
Lioncash
41c03f481a
service: Add ptm::gets and ptm::sets services
2016-12-08 05:43:08 -05:00
Lioncash
2061d2014d
service: Add mvd and qtm services
...
Adds the two New3DS-only modules.
3dbrew was used for command information.
2016-12-08 04:34:03 -05:00
Lioncash
e8a960f6a1
service: Add nfc services
...
3dbrew was used for the command information.
2016-12-08 03:24:41 -05:00
Lioncash
a09602d6f6
ssl_c: Update function table
...
Updated based off information from 3dbrew
2016-12-08 00:57:53 -05:00
Lioncash
ab900f8a25
ptm: Update ptm_sysm function table
...
Updated based off information from 3dbrew.
2016-12-08 00:57:53 -05:00
Lioncash
c67dae54b9
pm_app: Update function table
...
Updated based off information from 3dbrew.
2016-12-08 00:57:45 -05:00
Lioncash
9f2ad62084
nwm_uds: Update function table
...
Updated based off information from 3dbrew.
2016-12-08 00:56:47 -05:00
Lioncash
4a150a8f3c
nim: Update function tables
...
Updated based off information from 3dbrew.
2016-12-08 00:56:47 -05:00
Lioncash
c4bcd5c4ac
http_c: Update function table
...
Updated based off information from 3dbrew.
2016-12-08 00:56:47 -05:00
Lioncash
65d94857c3
gsp_lcd: Update function table
...
Updated based off information from 3dbrew.
2016-12-08 00:56:47 -05:00
Lioncash
006e6a7f4a
fs_user: Update function table
...
Updated based off information from 3dbrew.
2016-12-08 00:56:46 -05:00
Lioncash
093aa35c87
dlp_srvr: Update function table
2016-12-08 00:56:46 -05:00
Lioncash
733c8890aa
cfg: Update function tables
...
Updated based off information from 3dbrew
2016-12-08 00:56:46 -05:00
Lioncash
0229983ff2
cecd_u: Update function table
...
Updated based off information from 3dbrew.
2016-12-08 00:56:46 -05:00
Lioncash
4ebdb7e3e1
boss_p: Update function table
2016-12-08 00:56:45 -05:00