Subv
a7a5c5aa0d
Kernel/IPC: Partially implement MappedBuffer translation.
...
Right now only MappedBuffers that only span a single page and are not aligned are implemented.
MappedBuffers are unmapped during the reply part of ReplyAndReceive. Only unmapping of ReadOnly buffers is currently implemented.
2018-01-23 08:27:00 -05:00
Subv
928202f744
Kernel/VMManager: Added a function to map a block of memory into the first available address after a given base.
2018-01-23 08:24:15 -05:00
Subv
07089cfb3c
Tests: Added some tests for the VMManager class.
...
Covering basic operations like mapping, unmapping, reprotecting and changing memory state.
2018-01-23 08:21:12 -05:00
Subv
e4f35f70ac
Memory: Added a function to change the memory state of an address range.
...
This will be useful when implementing memory aliasing operations.
2018-01-23 08:19:47 -05:00
Subv
34685f48dc
GSP: Allow the signaling of the PDC0/1 interrupts even if the GPU right hasn't been acquired.
...
This was verified with a hwtest.
2018-01-06 13:51:33 -05:00
Subv
aa90198ec5
Services: Make SessionDataBase's destructor virtual.
2018-01-03 10:52:46 -05:00
Subv
75f68c4860
Services/GSP: Mark the thread ids as unused when a GSP session is destroyed.
...
This fixes the games that call RegisterInterruptRelayQueue and UnregisterInterruptRelayQueue frequently.
2018-01-02 12:10:58 -05:00
Subv
d17f148e48
Services/GSP: Assign a thread id to each connected session when the session is created.
...
Most applications call AcquireRight before calling RegisterInterruptRelayQueue so we can't assign the thread id there.
This fixes the bug with LLE applets not launching properly.
2018-01-02 12:07:26 -05:00
Subv
fbef978b98
GSP: Return the correct result code if AcquireRight is called multiple times from the same thread.
2017-12-24 12:15:01 -05:00
Subv
68fc3b36e6
HLE/GSP: Only trigger GSP interrupts for the current active GSP thread.
...
This is true for all interrupts except PDC0 and PDC1, which should be triggered for all registered threads.
TODO: The real GSP module seems to only trigger PDC0 after updating the screens (both top and bottom). PDC1 doesn't seem to be triggered at all.
2017-12-24 12:15:00 -05:00
Subv
05a44ed353
HLE/GSP: Keep track of the thread that currently has the GPU right.
...
This thread is the only one for which the GSP interrupts should be signaled, except for the PDC0/1 interrupts.
2017-12-24 12:14:59 -05:00
Subv
aabb07cca4
HLE/GSP: Make RegisterInterruptRelayQueue work in a per-session basis.
...
The registered interrupt event is unique to each session that calls RegisterInterruptRelayQueue, and only that event should be reset when UnregisterInterruptRelayQueue is called.
2017-12-24 12:14:58 -05:00
Sebastian Valle and GitHub
c3c684cd2b
Merge pull request #3301 from Subv/exitprocess2
...
Kernel/SVC: Partially implemented svcExitProcess.
2017-12-23 10:49:36 -05:00
Sebastian Valle and GitHub
ae42267cc7
Merge pull request #3307 from Subv/gsp_new_frame
...
HLE: Convert GSP_GPU to ServiceFramework.
2017-12-21 10:31:41 -05:00
Subv
3652809408
HLE: Convert GSP_GPU to ServiceFramework.
...
The only functional change is the error handling of GSP_GPU::ReadHWRegs function. We previously didn't return error codes (not even for success). The new returns were found by reverse engineering the GSP module.
2017-12-21 10:30:22 -05:00
Subv
f4b595331f
GSP/GPU: Make FrameBufferInfo::active_fb use the entire u32 instead of just one bit.
...
The GSP module reads the entire 32 bit word from this field to determine the framebuffer.
2017-12-16 13:33:42 -05:00
Sebastian Valle and GitHub
125f5d1e68
Merge pull request #3284 from Subv/session_data
...
HLE/Services: Allow specifying a SessionData template parameter to ServiceFramework.
2017-12-16 09:14:34 -05:00
Subv
1856aa7b32
Kernel/SVC: Partially implemented svcExitProcess.
...
Terminating processes with ready threads is not currently implemented and will assert. It is currently unknown how the 3DS kernel stops ready threads or threads running in another core.
2017-12-15 15:47:33 -05:00
Sebastian Valle and GitHub
4fd28e715e
Merge pull request #3252 from Subv/fs_user
...
HLE/FS: Converted some functions to use IPCHelpers
2017-12-15 15:40:36 -05:00
Sebastian Valle and GitHub
4b4e1861c7
Merge pull request #3265 from Subv/getappletinfo
...
HLE/APT: Implement GetAppletInfo for LLE applets.
2017-12-15 10:29:53 -05:00
Subv
9a22e8d9ed
HLE/APT: Implement GetAppletInfo for LLE applets.
...
Calling this function for AppletId::Application is not yet implemented because we don't support launching applications from APT.
2017-12-14 19:30:12 -05:00
Subv
674bd550a4
HLE/APT: Stubbed FinishPreloadingLibraryApplet.
...
An applet is considered "loaded" when the parent application calls this function.
2017-12-14 19:30:11 -05:00
Sebastian Valle and GitHub
542f14d3c5
Merge pull request #3249 from Subv/logo
...
NCCH: Load the "logo" file from the specified offset if it's present instead of the ExeFS.
2017-12-14 18:30:19 -05:00
Subv
b5bfaaae29
HLE/FS: Use the SessionData parameter of ServiceFramework in the File class.
2017-12-14 18:24:03 -05:00
Subv
daecd812b0
HLE/Services: Allow specifying a SessionData template parameter to ServiceFramework.
...
Some services can have multiple clients at the same time, and they identify the different clients using the server session as a key.
This parameter (if present) should be a structure that contains the per-session data for each service.
The data can be retrieved using ServiceFramework::GetSessionData(session)
2017-12-14 18:24:02 -05:00
Subv
2552efac01
HLE/FS: Use PopEnum in OpenFile.
2017-12-13 19:51:36 -05:00
Subv
d790ac465c
HLE/FS: Use IPCHelper in CreateFile.
2017-12-13 19:51:21 -05:00
Subv
92e71aff57
HLE/FS: Use IPCHelper in DeleteDirectoryRecursively.
2017-12-12 17:48:15 -05:00
Subv
67382e46c0
HLE/FS: Use IPCHelper in DeleteDirectory.
2017-12-12 17:48:12 -05:00
Subv
b631f77d11
HLE/FS: Use IPCHelper in RenameFile.
2017-12-12 17:48:10 -05:00
Subv
a6c69bfca0
HLE/FS: Use IPCHelper in DeleteFile.
2017-12-12 17:48:07 -05:00
Subv
e9a70ce2fc
HLE/FS: Use IPCHelper in OpenFileDirectly.
2017-12-12 17:48:03 -05:00
Subv
90fdc8dcbf
FS: Make LowPathType a strongly typed enum.
2017-12-12 17:48:00 -05:00
Sebastian Valle and GitHub
6afd091c37
Merge pull request #3235 from Subv/dlp3
...
HLE/FS: Implemented FSFile::OpenSubFile.
2017-12-12 17:01:18 -05:00
Subv
c9ddd5b0ae
HLE/FS: Implemented FSFile::OpenSubFile.
...
The File class now holds a list of connected sessions along with data unique to each session.
A subfile is a window into an existing file. They have a few limitations compared to normal files:
* They can't be written to.
* They can't be flushed.
* Their size can not be changed.
* New subfiles can't be created from another subfile.
2017-12-12 13:34:02 -05:00
Sebastian Valle and GitHub
b4bb74a101
Merge pull request #3268 from lioncash/ipc-enum
...
ipc_helpers: Add member functions for pushing and popping strongly typed enums
2017-12-12 12:52:02 -05:00
Sebastian Valle and GitHub
1e3113b1b2
Merge pull request #3251 from Subv/fs_numseeds
...
HLE/FS: Stubbed GetNumSeeds to always return 0 seeds.
2017-12-11 14:13:10 -05:00
Sebastian Valle and GitHub
4a3d7863fa
Merge pull request #3250 from Subv/news_notifications
...
HLE/News: Stubbed GetTotalNotifications to always return 0 notifications.
2017-12-11 14:12:22 -05:00
Subv
0ac82af50f
HLE/FS: Stubbed GetNumSeeds to always return 0 seeds.
...
We don't yet implement the SEEDDB store.
This number is supposed to be modified by the AddSeed function (0x087A0180) but there's too little info about it on 3dbrew.
2017-12-10 13:08:04 -05:00
Subv
98e3872353
Kernel/IPC: Use 39 microseconds for the SendSyncRequest delay approximation.
...
As measured by the time it takes for to return when performing the SetLcdForceBlack IPC request to the GSP:GPU service in a n3DS with firmware 11.6
See https://gist.github.com/ds84182/ecdbbd25b56a29bd4e5b32a7544b8e92 for the source code of the test.
2017-12-10 13:00:05 -05:00
Sebastian Valle and GitHub
c72262d7e3
Merge pull request #3246 from Steveice10/pxidev
...
HLE: Add pxi:dev stub.
2017-12-10 12:21:35 -05:00
Sebastian Valle and GitHub
2859b98884
Merge pull request #3234 from Subv/dlp2
...
HLE/FS: Implemented FS::GetProgramLaunchInfo.
2017-12-10 08:58:08 -05:00
Sebastian Valle and GitHub
951b023a3d
Merge pull request #3259 from lioncash/init-order
...
ac: Correct constructor initialization order
2017-12-10 08:46:11 -05:00
Sebastian Valle and GitHub
ae82b8d5cc
Merge pull request #3232 from Dragios/add-applet-id
...
Services/APT: Add remaining Applet IDs
2017-12-09 21:12:25 -05:00
Sebastian Valle and GitHub
176ed77506
Merge pull request #3255 from yuriks/trim-cryptopp
...
cryptopp: Build only required files
2017-12-09 21:07:58 -05:00
Subv
7d038b9bd8
HLE/FS: Implemented FS::GetProgramLaunchInfo.
...
This function is used by the DLP system module during the DLPSRVR initialization.
2017-12-09 18:46:34 -05:00
Subv
8e9b55e939
NCCH: Load the "logo" file from the specified offset if it's present instead of the ExeFS.
...
This is "new" behavior as of firmware 5.0.0-11, older titles have the logo offset and size set to 0, indicating that the logo is stored in the ExeFS.
2017-12-09 12:17:02 -05:00
Subv
dd0bd5520d
HLE/News: Stubbed GetTotalNotifications to always return 0 notifications.
...
This prevents an invalid read loop on games that call it.
2017-12-09 11:28:57 -05:00
Subv
b54e278eeb
FS/ExtData: Use the ExtSaveDataArchivePath structure instead of reinterpret_cast.
2017-12-09 00:17:43 -05:00
Subv
37cb18358b
HLE/FS: Always use 0x48000 as the high dword when opening the SharedExtData archive
...
The FS module overrides whatever value was in the saveid high dword with 0x48000 when trying to open the archive.
This fixes the problem where the Home Menu would create a few SharedExtData archives with 0x48000 as the saveid high, but then try to open them with 0 as the high value and fail.
2017-12-09 00:16:51 -05:00
Sebastian Valle and GitHub
69caf8c5dc
Merge pull request #3236 from Tilka/block_name
...
cfg: refer to ConsoleModelBlockID by name
2017-12-08 09:01:22 -05:00
Sebastian Valle and GitHub
065ae0606b
Merge pull request #3238 from lioncash/svc-name
...
svc: Provide names for svc 0x59 and 0x5A
2017-12-08 09:00:36 -05:00
Subv
e90daa6a4f
Kernel/IPC: Add a small delay after each SyncRequest to prevent thread starvation.
...
In a real 3DS, threads that call svcSyncRequest are put to sleep until the server responds via svcReplyAndReceive. Our HLE services don't implement this mechanism and are effectively immediate from the 3DS's point of view. This commit makes it so that we at least simulate the IPC delay.
Specific HLE handlers might need to put their callers to sleep for a longer period of time to simulate IO timings. This is their responsibility but doing so is currently not implemented.
See https://gist.github.com/ds84182/4a7690c5376e045cab9129ca4185bbeb for a test that was not passing before this commit.
2017-12-07 22:40:15 -05:00
Sebastian Valle and GitHub
4b1253b51a
Merge pull request #3226 from Subv/arbiter_timeout
...
HLE/AddressArbiter: Remove threads that were awoken by timeout from an Arbiter's waitlist
2017-12-06 12:11:23 -05:00
Subv
8c16b90eae
HLE/AddressArbiter: Remove threads that were awoken by timeout from the arbiter's waitlist when using WaitIfLessThanWithTimeout and DecrementAndWaitIfLessThanWithTimeout.
...
Fixes a regression introduced in #3096
2017-12-06 09:06:45 -05:00
Sebastian Valle and GitHub
36a8bc6db0
Merge pull request #3225 from B3n30/applet_id
...
Applet: Print unknown AppletId on ASSERT
2017-12-06 08:02:55 -05:00
Sebastian Valle and GitHub
4835342032
Merge pull request #3193 from Tilka/nan_check
...
video_core: optimize NaN check
2017-12-05 19:08:58 -05:00
Sebastian Valle and GitHub
81fbe06915
Merge pull request #3191 from wwylele/fs-fix
...
fs: correct header code; remove dead code
2017-12-05 10:57:39 -05:00
Subv
30bffb1964
HLE/Services: Convert err:f to the new ServiceFramework.
2017-12-04 14:03:11 -05:00
Sebastian Valle and GitHub
dc5d7a802f
Merge pull request #3120 from shinyquagsire23/ncch-container-offsets
...
file_sys/ncch_container: Expose ncch_offset during instantiation and in OpenFile
2017-11-28 11:48:46 -05:00
Sebastian Valle and GitHub
283ab8e693
Merge pull request #3160 from Subv/hle_ipc_assert
...
HLE/IPC: Don't assert in HLERequestContext::AddStaticBuffer when there's already a static buffer with the desired id
2017-11-28 10:19:29 -05:00
Subv
1be31e271a
NS/Applets: Added the MiiSelector applet to the list of native applet ids.
2017-11-28 09:12:52 -05:00
Subv
9543e1a1bf
HLE/IPC: Don't assert in HLERequestContext::AddStaticBuffer when there's already a static buffer with the desired id.
...
This could happen if the guest application performs a request with static buffer id X, and the service module responds with another static buffer with the same id X.
2017-11-28 09:01:15 -05:00
Sebastian Valle and GitHub
555c8ba7c1
Merge pull request #3077 from Subv/hle_static_buffer
...
Kernel/IPC: Implement StaticBuffer translation for HLE services that use the HLERequestContext architecture.
2017-11-19 11:34:02 -05:00
Sebastian Valle and GitHub
ff275ac1e1
Merge pull request #3083 from Subv/lle_staticbuffer_translation
...
Kernel/IPC: Handle the StaticBuffer descriptor in LLE command requests.
2017-11-19 11:31:49 -05:00
Sebastian Valle and GitHub
947067de81
Merge pull request #3085 from Subv/get_service_handle
...
HLE/SRV: Don't return the port handle if it isn't available when calling GetServiceHandle.
2017-11-15 13:46:12 -05:00
Subv
afb6dd7747
HLE/SRV: Don't return the port handle if it isn't available when calling GetServiceHandle.
...
This was incorrect behavior that somehow found its way to 3dbrew. The correct behavior is to sleep until the port becomes available again and then return a session to it.
This is currently unimplemented due to the inability to put a guest thread to sleep during HLE requests.
The correct behavior was reverse engineered by TuxSH a while ago but we never corrected the code in citra.
2017-11-15 11:26:49 -05:00
Sebastian Valle and GitHub
f0027e9996
Merge pull request #3096 from Subv/arbitrateaddress
...
Kernel/Arbiters: When doing ArbitrateAddress(Signal), always pick the highest priority thread, using the first one that was put to sleep if more than one thread with the same highest priority exists.
2017-11-15 09:16:16 -05:00
Sebastian Valle and GitHub
93742ec510
Merge pull request #3088 from Subv/clientsession_closing
...
Kernel/Sessions: Wake up any threads waiting on a ServerSession when its client is closed
2017-11-15 09:15:34 -05:00
Subv
35a61ab053
HLE/Tests: Added tests for the StaticBuffer IPC HLE translation.
2017-11-12 11:00:00 -05:00
Subv
c9c1ba0952
Kernel/IPC: Implement StaticBuffer translation for HLE services that use the HLERequestContext architecture.
...
The real kernel requires services to set up their static buffer targets ahead of time. This implementation does not require that and will simply create the storage for the buffers as they are processed in the incoming IPC request.
Static buffers are kept in an unordered_map keyed by their buffer id, and are written into the already-setup area of the request thread when responding an IPC request.
This fixes a regression (crash) introduced in #2992 .
This PR introduces more warnings due to the [[deprecated]] attribute being added to void PushStaticBuffer(VAddr buffer_vaddr, size_t size, u8 buffer_id); and VAddr PopStaticBuffer(size_t* data_size);
2017-11-12 11:00:00 -05:00
Subv
c68adb787b
Kernel/Arbiters: When doing ArbitrateAddress(Signal), always pick the highest priority thread, using the first one that was put to sleep if more than one thread with the same highest priority exists.
...
This is consistent with hardware behavior as shown by this test https://gist.github.com/ds84182/40e46129bd38b46a5100f15f96ba5eaf
2017-11-08 18:47:08 -05:00
Sebastian Valle and GitHub
908dbf4230
Merge pull request #3084 from Subv/thread_default_cpu
...
Kernel/Thread: Use the process' ideal CPU when specifying the Default CPU on CreateThread.
2017-11-08 14:38:50 -05:00
Sebastian Valle and GitHub
67df3c2c38
Merge pull request #3092 from BreadFish64/patch-1
...
Get Rid of Redundant ! in CIA loading code.
2017-11-08 14:38:20 -05:00
Subv
5e9d76337d
Build: Added missing <array> includes to title_metadata.h and cia_container.h
2017-11-07 22:06:34 -05:00
Subv
d683d34aa4
Filesys: Added some missing headers to the CMakeLists.txt after the recent stream of PRs.
2017-11-07 22:04:51 -05:00
Sebastian Valle and GitHub
7d12aaaa20
Merge pull request #3087 from shinyquagsire23/am-more-errors
...
Services/AM: Add errors and adjust naming for accuracy
2017-11-07 09:09:48 -05:00
Subv
06a2e0b591
Kernel/Sessions: Wake up any threads waiting on a ServerSession when its client is closed
...
The error code 0xC920181A will be returned by svcReplyAndReceive when the wakeup callback runs.
This lets LLE services be properly notified of clients closing the connection so they can end their handler threads instead of letting them linger indefinitely, taking up connection slots in their parent port.
2017-11-06 23:07:08 -05:00
Subv
d1de6b8864
HLE/APT: Try to launch a native applet in PrepareToStartLibraryApplet and PreloadLibraryApplet before falling back to HLE applets.
...
With this commit, you can run native applets if they are in the correct folder of your virtual NAND.
Trying to exit the applet will currently cause an invalid read loop due to svcExitProcess not being implemented.
2017-11-06 16:42:26 -05:00
Subv
ecb1c6d2a1
HLE/APT: Added a function to retrieve the titleid of an applet based on the current system region.
...
The table was taken from the real APT service, but is incomplete due to the sheer amount of data it contains. There's 29 applets with 7 possible titleids. This table should be filled as needed.
2017-11-06 16:42:26 -05:00
Subv
191565a1b8
HLE/NS: Added a function to launch titles installed to the virtual NAND/SD card.
...
It uses AM::GetTitleContentPath to retrieve the path of the program to launch.
2017-11-06 15:12:15 -05:00
Subv
ccd0710e5b
Logging: Add a Service_NS log class for the NS service.
2017-11-06 14:51:57 -05:00
Sebastian Valle and GitHub
c6b2cc2e27
Merge pull request #3082 from Subv/main_thread_processor
...
Kernel/Thread: Run the main thread in the CPU specified by the process' exheader.
2017-11-06 14:00:24 -05:00
Subv
a288c2e737
Kernel/Thread: Use the process' ideal CPU when specifying the Default CPU on CreateThread.
...
This behavior was reverse engineered from the real kernel.
2017-11-06 13:47:48 -05:00
Subv
2d9e295e07
Kernel/IPC: Handle the StaticBuffer descriptor in LLE command requests.
...
This descriptor requires the target process to set up a "receive buffer" beforehand, where the input data will be written to when the descriptor is processed.
2017-11-06 13:30:31 -05:00
Subv
980df62397
Kernel/Thread: Run the main thread in the CPU specified by the process' exheader.
...
System services usually have Core1 in this field, but citra was running them in Core0 regardless.
2017-11-06 13:14:31 -05:00
Sebastian Valle and GitHub
d55a13c35d
Merge pull request #2981 from Subv/replyreceive
...
Kernel/SVC: Implement LLE command buffer translation in ReplyAndReceive
2017-11-06 13:02:30 -05:00
Subv
23deae4785
Debugging: Implement GetName for Kernel::ServerSession.
...
Fixes the "[UNKNOWN KERNEL OBJECT]" message in the wait tree when inspecting a server session.
2017-11-06 10:47:06 -05:00
Subv
5f92dc963c
Kernel/SVC: Implement LLE command buffer translation in ReplyAndReceive.
...
The real kernel's ReplyAndReceive will retry the call until one of the objects can be acquired without causing a translation error, this is not currently implemented and the code will instead assert that the translation was a success.
2017-11-06 10:47:04 -05:00
Subv
8f108367c9
Kernel/IPC: Put a thread to sleep when performing an LLE IPC request.
...
It will be awoken when the server replies to the request via svcReplyAndReceive.
2017-11-06 10:46:19 -05:00
Subv
33c5982f6d
Kernel/Threads: Added a new thread status to identify threads waiting for an IPC reply from svcSendSyncRequest.
2017-11-06 10:46:19 -05:00
Subv
8e2d9f48f5
Kernel/IPC: Remove dead buffer translation code.
...
This is all implemented elsewhere, HLERequestContext for HLE requests, and svcReplyAndReceive for LLE requests.
2017-11-06 10:46:18 -05:00
Subv
7cf7999e02
Kernel/IPC: Added a function to translate the IPC command buffer from one process to another.
...
Currently only CopyHandle, MoveHandle and CallingPid descriptors are implemented.
2017-11-06 10:46:12 -05:00
Sebastian Valle and GitHub
ff17773c28
Kernel/Mutex: Add a missing return in Mutex::Release
...
Fixes a regression in #3042 .
Closes #3079
2017-11-05 21:31:22 -05:00
Sebastian Valle and GitHub
8ba2de1580
Merge pull request #3029 from shinyquagsire23/am-title-install
...
Services/AM: Add CIA title installation support.
2017-11-05 21:23:55 -05:00
Subv
d4077b0196
Services/AC: Corrected the number of concurrent connections for AC_I and AC_U
...
The number was reverse engineered from the AC module.
2017-11-05 14:28:06 -05:00
Sebastian Valle and GitHub
9a52d72362
Merge pull request #3042 from Subv/releasemutex
...
Kernel/SVC: Don't let svcReleaseMutex release a mutex owned by another thread
2017-11-04 12:57:44 -05:00
Sebastian Valle and GitHub
3fe9b332bc
Merge pull request #2989 from B3n30/sendTo_PullPacket_Bind
...
Service/UDS: Implement Bind, Unbind, SendTo, PullPacket, and GetNodeInformation
2017-11-04 10:58:49 -05:00
Subv
68dba11805
Kernel/SVC: Don't let svcReleaseMutex release a mutex owned by another thread.
...
This behavior was reverse engineered from the 3DS kernel.
2017-11-04 10:05:18 -05:00
Sebastian Valle and GitHub
c575e6b202
Merge pull request #3060 from superheri/WordOrderComment
...
Correcting word order of a comment in memory.cpp
2017-10-28 12:37:58 -05:00